This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fix value of params[:pr] when useing CodeBuild #102
Merged
thomasrockhu merged 1 commit intocodecov:masterfrom Sep 15, 2020
Merged
Fix value of params[:pr] when useing CodeBuild #102thomasrockhu merged 1 commit intocodecov:masterfrom
thomasrockhu merged 1 commit intocodecov:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 91.80% 91.85% +0.04%
==========================================
Files 1 1
Lines 354 356 +2
==========================================
+ Hits 325 327 +2
Misses 29 29
Continue to review full report at Codecov.
|
neko314
force-pushed
the
fix_codebuild_source_version_regexp
branch
2 times, most recently
from
171715b to
34fd5bb
Compare
neko314
changed the title
According to AWS CodeBuild User Guide, CODEBUILD_SOURCE_VERSION depends on the source repository. When build is triggered by a webhook pull request event, the value is pull_request number(pr/xxx) otherwise the value is other than pull request number(commit id, branch name or tag name). In the latter case, an error raises like below. ``` /root/caches/vendor/bundle/ruby/2.5.0/gems/codecov-0.2.11/lib/codecov.rb:171 :in `build_params': undefined method `[]' for nil:NilClass (NoMethodError) ```
neko314
force-pushed
the
fix_codebuild_source_version_regexp
branch
from
34fd5bb to
54bc8b4
Compare
thomasrockhu
approved these changes
Sep 15, 2020
Contributor
thomasrockhu
left a comment
thomasrockhu
left a comment
There was a problem hiding this comment.
Thanks here @neko314, I'll release this week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of
CODE_BUILD_SOURCE_VERSIONis not only pull request number but also commit id, branch name and tag name.AWS says like this in the documentation.
When the value is not pull request number, an error raises so I fix the code.
Here's error messages.