Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Fix error try_to_run using | without shell=True (fix #284) #298

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

paugier
Copy link
Contributor

@paugier paugier commented Sep 18, 2020

With ['hg', 'log', '-r', '.', '-T', '{node}'] to avoid shell=True.

Should fix #284

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #298   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           2      2           
  Lines           9      9           
=====================================
  Hits            8      8           
  Misses          1      1           

@thomasrockhu
Copy link
Contributor

Thanks for this @paugier!

@thomasrockhu thomasrockhu merged commit 713d941 into codecov:master Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hg identify call fails because it uses a |, but try_to_run() is missing shell=True
2 participants