Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Upgrading Request #77

Merged
merged 2 commits into from
Oct 23, 2017
Merged

Upgrading Request #77

merged 2 commits into from
Oct 23, 2017

Conversation

eddiemoore
Copy link
Collaborator

Closes #74

Upgrading to the latest version of request
Removing node 0.12 from versions

@codecov
Copy link

codecov bot commented Oct 23, 2017

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files          18       18           
  Lines         264      264           
  Branches       57       57           
=======================================
  Hits          239      239           
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5854e...1ccff10. Read the comment docs.

@eddiemoore eddiemoore merged commit 4103436 into master Oct 23, 2017
@eddiemoore eddiemoore deleted the fix/request branch October 23, 2017 06:26
@aoberoi
Copy link
Contributor

aoberoi commented Oct 24, 2017

@eddiemoore did you make a mistake in going backwards a version? I think this should be released as 3.0.0.

FYI, you cannot unpublish from npm, so 2.3.1 is still the latest version. I don’t think this change will have the outcome we need to fix #74

@eddiemoore
Copy link
Collaborator Author

v3.0.0 is already released @aoberoi

@aoberoi
Copy link
Contributor

aoberoi commented Oct 24, 2017

My bad!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants