Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use azure pipelines PR commit ID #474

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: use azure pipelines PR commit ID #474

merged 1 commit into from
Jul 15, 2024

Conversation

gtbuchanan
Copy link
Contributor

@gtbuchanan gtbuchanan commented Jul 15, 2024

In the case of pull requests, Build.SourceVersion contains the commit ID of the merge commit. System.PullRequest.SourceCommitId contains the source commit ID of the pull request, so it should be checked first.

Resolves: https://codecovpro.zendesk.com/hc/en-us/requests/126441
Docs: https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml

In the case of pull requests, Build.SourceVersion contains the commit ID
of the merge commit. System.PullRequest.SourceCommitId contains the
source commit ID of the pull request, so it should be checked first.
@thomasrockhu-codecov thomasrockhu-codecov merged commit fd37150 into codecov:main Jul 15, 2024
22 checks passed
@gtbuchanan gtbuchanan deleted the fix/azp-commit branch July 15, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants