-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding builds for main and some reusable workflows #279
Conversation
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 95.42% 95.52% +0.10%
==========================================
Files 78 79 +1
Lines 2643 2729 +86
==========================================
+ Hits 2522 2607 +85
- Misses 121 122 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
db7a1c7
to
d7a76b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but I've messed up this release process very much very recently so....:E)
One thing I don't understand is the publish to Pypi only happens if we manually trigger the build_for_pypi workflow?
id: make-commit | ||
run: | | ||
sed -i 's/version="[0-9]\.[0-9]\.[0-9]"/version="${{ github.event.inputs.versionName }}"/g' setup.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
with: | ||
gpg_private_key: ${{ secrets.RELEASER_GPG_PRIVATE_KEY }} | ||
git_user_signingkey: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
pip install wheel | ||
python setup.py sdist bdist_wheel --plat-name=manylinux2014_x86_64 | ||
python setup.py bdist_wheel --plat-name=macosx-12.6-x86_64 | ||
python setup.py bdist_wheel --plat-name=win_amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anthony recommended not using bdist_wheel
and --plat-name
(and instead using the build
package instead): https://sentry.slack.com/archives/C04DL8SRBUZ/p1696528344746259?thread_ts=1696526939.075939&cid=C04DL8SRBUZ
Should we address that later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I want us to take a pass at making this better as a different initiative. The goal here is to improve the overall workflow first.
No description provided.