Adding builds for main and some reusable workflows #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 95.42% 95.52% +0.10%
==========================================
Files 78 79 +1
Lines 2643 2729 +86
==========================================
+ Hits 2522 2607 +85
- Misses 121 122 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
trent-codecov
force-pushed
the
feature/main-builds
branch
from
db7a1c7
to
d7a76b2
Compare
| id: make-commit | ||
| run: | | ||
| sed -i 's/version="[0-9]\.[0-9]\.[0-9]"/version="${{ github.event.inputs.versionName }}"/g' setup.py |
| with: | ||
| gpg_private_key: ${{ secrets.RELEASER_GPG_PRIVATE_KEY }} | ||
| git_user_signingkey: true |
| pip install wheel | ||
| python setup.py sdist bdist_wheel --plat-name=manylinux2014_x86_64 | ||
| python setup.py bdist_wheel --plat-name=macosx-12.6-x86_64 | ||
| python setup.py bdist_wheel --plat-name=win_amd64 |
There was a problem hiding this comment.
Anthony recommended not using bdist_wheel and --plat-name (and instead using the build package instead): https://sentry.slack.com/archives/C04DL8SRBUZ/p1696528344746259?thread_ts=1696526939.075939&cid=C04DL8SRBUZ
Should we address that later?
There was a problem hiding this comment.
Yes, I want us to take a pass at making this better as a different initiative. The goal here is to improve the overall workflow first.
scott-codecov
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.