This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
env: Ensure proper detection of CircleCI #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures all parameters required by the python [1] and bash [2] uploader can easily be passed to a docker container [3] [1] https://github.com/codecov/codecov-python/blob/7386c3c13fc71f237611c780646fa1b44a07dc64/codecov/__init__.py#L337 [2] https://github.com/codecov/codecov-bash/blob/441e2018ed76f4d8cb92dafa732ee24ebebb41f9/codecov#L429 [3] http://docs.codecov.io/docs/testing-with-docker#section-codecov-inside-docker
jcfr
added a commit
to scikit-build/cmake-python-distributions
that referenced
this pull request
Nov 9, 2016
…"-e CI" Issue has been reported upstream as codecov/codecov-bash#47
|
Thank you! 👍 |
|
Thanks for reviewing and integrating 👍 |
evantorrie
pushed a commit
to evantorrie/codecov-bash
that referenced
this pull request
Aug 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures all parameters required by the python [1] and bash [2] uploader can easily be passed to a docker container [3]
[1] https://github.com/codecov/codecov-python/blob/7386c3c13fc71f237611c780646fa1b44a07dc64/codecov/__init__.py#L337
[2]
codecov-bash/codecov
Line 429 in 441e201
[3] http://docs.codecov.io/docs/testing-with-docker#section-codecov-inside-docker