This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Update CodeBuild CI detection to use CODEBUILD_CI env var #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibrahim0814 |
|
Thank you @rasarora Can I ask you to update the SHA1SUM file again, please? |
rasarora
force-pushed
the
codebuild-codecov-bash-integration
branch
from
53b5b88 to
4a84d41
Compare
rasarora
force-pushed
the
codebuild-codecov-bash-integration
branch
from
4a84d41 to
f51b7c8
Compare
|
Thanks @drazisil for reviewing this PR. I synced the branch with the existing codebase and updated the SHA1SUM file |
drazisil
approved these changes
Mar 3, 2020
|
Requested deployment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
What is the context of this pull request? Why is it being done?
Update CodeBuild CI detection to use CodeBuild's environment variable for CI: CODEBUILD_CI
Notable Changes
Are there any changes that need to be called out as particularly tricky or significant?
N/A
Tests and Risks?
Is this covered by existing tests? New ones? If no, why not?
Yes
Update the SHA1SUM file
Also make sure that you update the sha1 hash by running
sha1sum codecovand updating the SHA1SUM file with the outputUpdated the SHA1SUM file