Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

[CE-919] Add AWS Codebuild support #220

Merged
merged 14 commits into from
Nov 6, 2019
Merged

[CE-919] Add AWS Codebuild support #220

merged 14 commits into from
Nov 6, 2019

Conversation

drazisil
Copy link
Contributor

Purpose

Add AWS Codebuild support

Notable Changes

No

Tests and Risks?

New tests

@drazisil drazisil changed the title Add tests Add AWS Codebuild support Oct 31, 2019
@drazisil
Copy link
Contributor Author

drazisil commented Nov 4, 2019

Closes #216

Copy link
Contributor

@ibrahim0814 ibrahim0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about double export, otherwise LGTM

tests/env Outdated Show resolved Hide resolved
@ibrahim0814
Copy link
Contributor

This is a good PR, shoutout to you @drazisil for killing it on adding CI support

@drazisil drazisil changed the title Add AWS Codebuild support [CE-919] Add AWS Codebuild support Nov 5, 2019
Copy link

@hootener hootener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming these env vars are correct. If you wanted to be especially helpful you could link to the codebuild docs with a comment that describes what these vars are, but i'm not going to block this PR over it. LGTM.

elif [ "$CODEBUILD_BUILD_ARN" != "" ];
then
say "$e==>$x AWS Codebuild detected."
# https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-env-vars.html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right here, @hootener :)

@drazisil drazisil merged commit 416cd41 into master Nov 6, 2019
@drazisil drazisil deleted the add_codebuild branch November 6, 2019 16:20
@drazisil
Copy link
Contributor Author

This has been deployed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants