-
Notifications
You must be signed in to change notification settings - Fork 155
Conversation
Closes #216 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about double export, otherwise LGTM
This is a good PR, shoutout to you @drazisil for killing it on adding CI support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming these env vars are correct. If you wanted to be especially helpful you could link to the codebuild docs with a comment that describes what these vars are, but i'm not going to block this PR over it. LGTM.
elif [ "$CODEBUILD_BUILD_ARN" != "" ]; | ||
then | ||
say "$e==>$x AWS Codebuild detected." | ||
# https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-env-vars.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right here, @hootener :)
This has been deployed |
Purpose
Add AWS Codebuild support
Notable Changes
No
Tests and Risks?
New tests