Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Correct support for GitHub Actions #218

Merged
merged 9 commits into from
Oct 31, 2019
Merged

Correct support for GitHub Actions #218

merged 9 commits into from
Oct 31, 2019

Conversation

drazisil
Copy link
Contributor

Purpose

To correct issues in the handling of GitHub Actions

Notable Changes

No

Tests and Risks?

Covered by existing tests

@drazisil drazisil changed the title Update env Correct support for GitHub Actions Oct 29, 2019
@drazisil drazisil requested a review from ibrahim0814 October 30, 2019 19:04
Copy link
Contributor

@ibrahim0814 ibrahim0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrahim0814
Copy link
Contributor

@drazisil Do you know why we have a Circle config for this repo if our tests are also running on Travis?

@drazisil
Copy link
Contributor Author

@ibrahim0814 I believe it is to show that the uploader can work on CodeCI. I'll address those issues in another PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants