Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing token example in README.md #1241

Closed
wants to merge 1 commit into from

Conversation

basnijholt
Copy link

The examples in the README are currently not working. One has to pass the token in the with: key, just like is done in the CI Actions in this repo.

The examples in the README are currently not working. One has to pass the token in the `with:` key, just like is done in the CI Actions in this repo.
@thomasrockhu-codecov
Copy link
Contributor

This has been fixed via #1243. Thank you for the PR

@webknjaz
Copy link
Contributor

webknjaz commented Feb 1, 2024

@thomasrockhu-codecov this should've been accepted instead. The token is what's documented and been used earlier. Also, using multiple configuration mechanisms (inputs + env vars) is poor UX. It's going to generate a lot of unnecessary changes in workflows because many already set the input correctly. Using action inputs is a traditional way of passing arguments in the GHA ecosystem. Env vars may be used sometimes but it's not as straigthforward to remember which ones need to be env vars and which ones are regular vars

@thomasrockhu-codecov
Copy link
Contributor

@webknjaz that's a fair point. However, we have other users who prefer to have it separated out in order to remember that is it a secret token. I have made a PR that updates the README with both versions with slight preference to using it under with:

@webknjaz
Copy link
Contributor

webknjaz commented Feb 1, 2024

@thomasrockhu-codecov the value literally says "secret" in the reference, in both cases. Neither "input", nor "with", nor "env" suggest secrets on their own.

@thomasrockhu-codecov
Copy link
Contributor

@webknjaz I'm not sure what you're asking for now

@webknjaz
Copy link
Contributor

webknjaz commented Feb 1, 2024

@thomasrockhu-codecov I just pointed out that your statement does not sound consistent with the perception of the env vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants