Update resource restrictions #42
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think we should keep the must language on the size limit. Even though we may not strictly enforce it today, my understanding is we very much intend to. I'd rather just keep the stronger language now than have to change it to be stronger later. |
* 512MB is a strongly recommended limit for Docker image size, but isn't strictly enforced, and isn't always feasible. The previous 256MB was too low. I've updated the limit, and changed "must" to "should". * Our default memory limit is also higher now, but is a strict limit. I've updated the memory limit. * Fix some typos. cc @mrb @codeclimate/review
wfleming
force-pushed
the
wf-resource-rewording
branch
from
3f9d32f to
d172985
Compare
Contributor
Author
|
@pbrisbin switched back to "must". |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mrb @codeclimate/review