Skip to content

Build cleanup #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2016
Merged

Build cleanup #52

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61b17b2
Add a Makefile
Feb 16, 2016
81b3491
CircleCI: use the Makefile
Feb 16, 2016
2a80509
add .dockerignore
Feb 16, 2016
70e4fd5
Dockerfile: set WORKDIR to /code
Feb 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CircleCI: use the Makefile
  • Loading branch information
Will Fleming committed Feb 16, 2016
commit 81b349106551a758493afa0a6e1558e88ef9747b
4 changes: 2 additions & 2 deletions circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ machine:

dependencies:
override:
- docker build -t=$PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM .
- echo "no-op"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄 extra line here

test:
override:
- docker run $PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM bundle exec rake
- IMAGE_NAME="$PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM" make test

deployment:
registry:
Expand Down