Only output timing information if debug is set to true. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to make STDERR quieter
Docker's buffers have issues when there is one really big line (see moby/moby#20119). When we overwrote `console.log`, we lost the `\n`. This could be causing issues.
|
Curious about motivation and whether there's a different spot that STDERR is getting in the way? Up to you, but maybe consider adding a note about motivation to commit message? One optional nit, otherwise LGTM. |
gdiggs
added a commit
that referenced
this pull request
Feb 9, 2016
Only output timing information if debug is set to true.
|
838f269 seems super important: that could have something to do with the "invalid output" issues we see from eslint regularly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make STDERR quieter
@codeclimate/review