Skip to content

Install npm as part of docker build #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Install npm as part of docker build #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87f38d3
Install npm as part of docker build
Jan 20, 2016
548e68f
update circle yml
Jan 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ COPY vendor/php-parser/composer.json /usr/src/app/vendor/php-parser/
COPY vendor/php-parser/composer.lock /usr/src/app/vendor/php-parser/

RUN curl --silent --location https://deb.nodesource.com/setup_5.x | bash -
RUN apt-get update && apt-get install -y nodejs python openssh-client php5-cli php5-json
RUN apt-get update && apt-get install -y nodejs npm python openssh-client php5-cli php5-json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ABaldwinHunter your issue is because of the dependency between the installation here and the nodesource install a line above. You should combine them to one RUN invocation with && so that they are cached (and invalidated) together.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbrisbin cool, thanks for the explanation!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in pull: https://github.com/codeclimate/codeclimate-duplication/compare/abh-dockerfile-update?expand=1

RUN gem install bundler --no-ri --no-rdoc && \
bundle install -j 4 && \
curl -sS https://getcomposer.org/installer | php
Expand Down
2 changes: 1 addition & 1 deletion circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ machine:
dependencies:
override:
- docker info
- docker build -t=$PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM .
- docker build --rm -t=$PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: --rm doesn't work on Circle because we don't have permissions to remove layers, it'll just spit warnings to stderr. Also, since 1.9, --rm is the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTK Thanks!


test:
override:
Expand Down