Catch RuntimeError when parsing #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubyParser raises `RuntimeError` instead of anything more specific in certain parse error contexts. This presents a challenge for catching these, since many error types (including `Timeout::Error`, which we don't want to catch) inherit from `RuntimeError`. So I've had to shift from two `rescue` clauses to one `rescue` clause that uses internal logic to decide if the error should be re-raised.
| rescue => ex | ||
| $stderr.puts("#{ex.class} error occurred processing file #{file}: aborting.") | ||
| raise ex | ||
| if RESCUABLE_ERRORS.map { |klass| ex.instance_of?(klass) }.include?(true) |
There was a problem hiding this comment.
Before anybody asks: ActiveSupport is not included in this gem, and it doesn't seem worth adding just for this.
|
LGTM |
wfleming
added a commit
that referenced
this pull request
Dec 30, 2015
Catch RuntimeError when parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RubyParser raises
RuntimeErrorinstead of anything more specific incertain parse error contexts.
This presents a challenge for catching these, since many error types
(including
Timeout::Error, which we don't want to catch) inherit fromRuntimeError. So I've had to shift from tworescueclauses to onerescueclause that uses internal logic to decide if the error shouldbe re-raised.
Updated follow-up to #64, @codeclimate/review.