Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

skip file message: format everything in one call #63

Merged
merged 1 commit into from
Dec 29, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
skip file message: format everything in one call
I noticed that some logs reporting skip file messages seemed to
interleave multiple messages: That's not terribly surprising due to
concurrency.

This changes the message formatting a bit & does it all in one method
call to avoid the threading issues.
  • Loading branch information
wfleming committed Dec 29, 2015
commit 52f3c2cf51a1d3f4b28a3d7b352434ab7f50379a
3 changes: 1 addition & 2 deletions lib/cc/engine/analyzers/analyzer_base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ def initialize(engine_config:)
def run(file)
process_file(file)
rescue *RESCUABLE_ERRORS => ex
$stderr.puts("Skipping file #{file} due to exception:")
$stderr.puts("(#{ex.class}) #{ex.message} #{ex.backtrace.join("\n")}")
$stderr.puts("Skipping file #{file} due to exception (#{ex.class}): #{ex.message}\n#{ex.backtrace.join("\n")}")
rescue => ex
$stderr.puts("#{ex.class} error occurred processing file #{file}: aborting.")
raise ex
Expand Down