Skip to content

Conversation

@Bhupesh-V
Copy link
Collaborator

No description provided.

- add authenticate() method for adding API_KEY
- change base API URLs
- Add custom API url
- use f-strings for urls
- wrote more tests
- fix how exceptions are raised
- wrote docs for api()
@pep8speaks
Copy link

pep8speaks commented Jul 12, 2020

Hello @Bhupesh-V! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 144:80: E501 line too long (86 > 79 characters)

Line 12:80: E501 line too long (85 > 79 characters)

Line 143:80: E501 line too long (80 > 79 characters)

Comment last updated at 2020-07-23 06:40:46 UTC

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #6 into master will decrease coverage by 27.71%.
The diff coverage is 86.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
- Coverage   88.28%   60.57%   -27.72%     
===========================================
  Files           3        3               
  Lines         222      175       -47     
===========================================
- Hits          196      106       -90     
- Misses         26       69       +43     
Impacted Files Coverage Δ
coderunner/coderunner.py 46.51% <68.42%> (-32.69%) ⬇️
tests.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea5b2e...f84965b. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2020

This pull request introduces 1 alert when merging 862e9eb into 7ea5b2e - view on LGTM.com

new alerts:

  • 1 for Unused import

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 12 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Bhupesh-V Bhupesh-V merged commit e257196 into master Jul 23, 2020
@Bhupesh-V Bhupesh-V deleted the dev branch July 23, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants