Skip to content

fix: complicated locator #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2024
Merged

fix: complicated locator #4170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/locator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class Locator {
*/
toXPath(pseudoSelector = '') {
const locator = `${this.value}${pseudoSelector}`;
const limitation = [':nth-of-type', ':first-of-type', ':last-of-type', ':nth-last-child', ':nth-last-of-type', ':checked', ':disabled', ':enabled', ':required', ':lang'];
const limitation = [':nth-of-type', ':first-of-type', ':last-of-type', ':nth-last-child', ':nth-last-of-type', ':checked', ':disabled', ':enabled', ':required', ':lang', ':nth-child'];

if (limitation.some(item => locator.includes(item))) {
cssToXPath = require('css-to-xpath');
Expand Down
154 changes: 138 additions & 16 deletions test/unit/locator_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,142 @@ const xml = `<body>
</div>
<input type="hidden" name="return_url" value="" id="return_url" />

<div class="ps-submenu-root">
<ul class="ps-submenu-root">
<li class="ps-menu-button">Adhemar da Silva</li>
<li class="ps-menu-button">HelloWorld</li>
<li class="ps-menu-button">Hallo</li>
</ul>
<ul class="ps-submenu-root">
<li class="ps-menu-button">Adhemar da Silva</li>
<li class="ps-menu-button">HelloWorld</li>
<li class="ps-menu-button">Authoring</li>
</ul>
</div>
<ul class="css-ewdv3l">
<li class="ps-menuitem-root css-dq4uaz">
<a
aria-current="page"
class="ps-menu-button active"
data-testid="ps-menu-button-test-id"
tabindex="0"
title="aaa"
href="/"
><span class="ps-menu-icon css-2wa2k3"
><i aria-hidden="true" class="icon home lg outline"></i></span
><span class="ps-menu-label css-12w9als">aaa</span></a
>
</li>
<li class="ps-menuitem-root ps-submenu-root css-x7nyah">
<a
class="ps-menu-button"
data-testid="ps-menu-button-test-id"
title="Dashboard"
tabindex="0"
><span class="ps-menu-icon css-2wa2k3"
><i
aria-hidden="true"
class="icon tachometer alternate"
></i></span
><span class="ps-menu-label css-12w9als">aaa</span
><span class="ps-submenu-expand-icon css-1cuxlhl"
><span class="css-honxw6"></span></span
></a>
</li>
<li class="ps-menuitem-root ps-submenu-root css-x7nyah">
<a
class="ps-menu-button"
data-testid="ps-menu-button-test-id"
title="aaa"
tabindex="0"
><span class="ps-menu-icon css-2wa2k3"
><i aria-hidden="true" class="icon books"></i></span
><span class="ps-menu-label css-12w9als">Authoring</span
><span class="ps-submenu-expand-icon css-1cuxlhl"
><span class="css-honxw6"></span></span
></a>
</li>
<li class="ps-menuitem-root ps-submenu-root css-x7nyah">
<a
class="ps-menu-button"
data-testid="ps-menu-button-test-id"
title="aaa"
tabindex="0"
><span class="ps-menu-icon css-2wa2k3"
><i aria-hidden="true" class="icon ballot check"></i></span
><span class="ps-menu-label css-12w9als">aaa</span
><span class="ps-submenu-expand-icon css-1cuxlhl"
><span class="css-honxw6"></span></span
></a>
</li>
<li class="ps-menuitem-root ps-submenu-root css-x7nyah">
<a
class="ps-menu-button"
data-testid="ps-menu-button-test-id"
title="aaa"
tabindex="0"
><span class="ps-menu-icon css-2wa2k3"
><i aria-hidden="true" class="icon book reader"></i></span
><span class="ps-menu-label css-12w9als">aaa</span
><span class="ps-submenu-expand-icon css-1cuxlhl"
><span class="css-honxw6"></span></span
></a>
</li>
<li class="ps-menuitem-root ps-submenu-root css-x7nyah">
<a
class="ps-menu-button"
data-testid="ps-menu-button-test-id"
title="aaa"
tabindex="0"
><span class="ps-menu-icon css-2wa2k3"
><i aria-hidden="true" class="icon school"></i></span
><span class="ps-menu-label css-12w9als">aaa</span
><span class="ps-submenu-expand-icon css-1cuxlhl"
><span class="css-honxw6"></span></span
></a>
</li>
<li class="ps-menuitem-root ps-submenu-root css-x7nyah">
<a
class="ps-menu-button"
data-testid="ps-menu-button-test-id"
title="aaa"
tabindex="0"
><span class="ps-menu-icon css-2wa2k3"
><i aria-hidden="true" class="icon user"></i></span
><span class="ps-menu-label css-12w9als">aaa</span
><span class="ps-submenu-expand-icon css-1cuxlhl"
><span class="css-honxw6"></span></span
></a>
</li>
<li class="ps-menuitem-root ps-submenu-root css-x7nyah">
<a
class="ps-menu-button"
data-testid="ps-menu-button-test-id"
title="aaa"
tabindex="0"
><span class="ps-menu-icon css-2wa2k3"
><i aria-hidden="true" class="icon cog"></i></span
><span class="ps-menu-label css-12w9als">aaa</span
><span class="ps-submenu-expand-icon css-1cuxlhl"
><span class="css-honxw6"></span></span
></a>
</li>
<li class="ps-menuitem-root ps-submenu-root css-x7nyah">
<a
class="ps-menu-button"
data-testid="ps-menu-button-test-id"
title="aaa"
tabindex="0"
><span class="ps-menu-icon css-2wa2k3"
><i aria-hidden="true" class="icon tablet alternate"></i></span
><span class="ps-menu-label css-12w9als">aaa</span
><span class="ps-submenu-expand-icon css-1cuxlhl"
><span class="css-honxw6"></span></span
></a>
</li>
<li class="ps-menuitem-root ps-submenu-root css-x7nyah">
<a
class="ps-menu-button"
data-testid="ps-menu-button-test-id"
title="aaa"
tabindex="0"
><span class="ps-menu-icon css-2wa2k3"
><i aria-hidden="true" class="icon tools"></i></span
><span class="ps-menu-label css-12w9als">aaa</span
><span class="ps-submenu-expand-icon css-1cuxlhl"
><span class="css-honxw6"></span></span
></a>
</li>
</ul>

</body>`;

describe('Locator', () => {
Expand Down Expand Up @@ -294,13 +418,11 @@ describe('Locator', () => {
});

it('should be able to locate complicated locator', () => {
const l = Locator.build('.ps-menu-button')
.withText('Authoring')
.inside('.ps-submenu-root:nth-child(2)');
const l = Locator.build('.ps-menu-button').withText('Authoring').inside('.ps-submenu-root:nth-child(3)');

const nodes = xpath.select(l.toXPath(), doc);
expect(nodes).to.have.length(1, l.toXPath());
expect(nodes[0].firstChild.data).to.eql('Authoring', l.toXPath());
expect(nodes[0].firstChild.nextSibling.firstChild.data).to.eql('Authoring', l.toXPath());
});

it('should find element with last of type with text', () => {
Expand Down