Skip to content

Conversation

@kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

export = new Factory()
   .attr('name', () => faker.name.findName())
   .attr('job', () => 'leader');
export default new Factory()
   .attr('name', () => faker.name.findName())
   .attr('job', () => 'leader');
modules.export = new Factory()
   .attr('name', () => faker.name.findName())
   .attr('job', () => 'leader');

@DavertMik may have concern on this, we encountered this once here #3691 (comment)

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent added enhancement typescript Changes for typings or typescript compatibility labels Oct 20, 2023
@kobenguyent kobenguyent linked an issue Oct 20, 2023 that may be closed by this pull request
@kobenguyent kobenguyent merged commit eba9a39 into 3.x Oct 28, 2023
@kobenguyent kobenguyent deleted the 3469-apidatafactory-with-typescript-factory-file-and-es6-export branch October 28, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement typescript Changes for typings or typescript compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ApiDataFactory with typescript factory file and ES6 export

3 participants