Skip to content

fix: rename haveRequestHeaders of ppt and pw helpers #3937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2023
Merged

fix: rename haveRequestHeaders of ppt and pw helpers #3937

merged 4 commits into from
Oct 28, 2023

Conversation

@kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

Renamed haveRequestHeaders of PPT, PW helper so that it would not confuse the REST helper.
PPT: setPuppeteerRequestHeaders
PW: setPlaywrightRequestHeaders

Applicable helpers:

  • Playwright
  • Puppeteer

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent linked an issue Oct 19, 2023 that may be closed by this pull request
Using haveRequestHeaders (REST, Playwright) #3630
Closed
@kobenguyent kobenguyent merged commit f78c027 into 3.x Oct 28, 2023
@kobenguyent kobenguyent deleted the 3630-using-haverequestheaders-rest-playwright branch October 28, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arhell Arhell Arhell approved these changes

Assignees

No one assigned

Labels

documentation playwright puppeteer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using haveRequestHeaders (REST, Playwright)

3 participants

@kobenguyent @Arhell