fix(pw): drag n drop issue #3692
Conversation
|
It's a Playwright issue in the feature implementation: microsoft/playwright#1094 We need to study the problem in more detail. Please don't merge it yet 🙏 |
lib/helper/Playwright.js
Outdated
| async dragAndDrop(srcElement, destElement, options = { force: true }) { | ||
| const src = new Locator(srcElement, 'css'); | ||
| const dst = new Locator(destElement, 'css'); | ||
| async dragAndDrop(srcElement, destElement) { |
There was a problem hiding this comment.
If I understand well, it would break my use case because you removed the options parameter:
// Move the object from default to initial position
I.dragAndDrop(konvajsFragment.gameArea, konvajsFragment.gameArea, {
sourcePosition: OBJECT_DEFAULT_POSITION,
targetPosition: OBJECT_INITIAL_POSITION,
});There was a problem hiding this comment.
with the new implementation, I don't feel like we need the options parameter.
There was a problem hiding this comment.
@kobenguyent
My use case is "Move an object from one position to another one inside an area (canvas)". Therefore I need to pass source and target coordinates to I.dragAndDrop().
There was a problem hiding this comment.
hey @mirao @EgorBodnar fixing for backward compatibility.
There was a problem hiding this comment.
hey @mirao @EgorBodnar fixing for backward compatibility.
great! Looks good
An additional flag would be more intuitive for users, but your solution is more elegant.
Motivation/Description of the PR
Applicable helpers:
Type of change
Checklist:
npm run docs)npm run lint)npm test)