adding downloadFile action for puppeteer #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavertMik This is following up the old PR -> #1343 |
DavertMik
requested changes
Mar 5, 2019
houndci-bot
reviewed
Mar 6, 2019
|
|
|
But not for Travis :( |
|
Should we skip that test on CI? |
|
Can we somehow figure out what's going wrong on Travis? |
|
@DavertMik oops, well, it's passed. -> https://travis-ci.org/Codeception/CodeceptJS/jobs/504583768
|
houndci-bot
reviewed
Mar 11, 2019
|
Thanks! |
DavertMik
pushed a commit
that referenced
this pull request
Mar 15, 2019
* Synced with master (#1) * Handle trailing comma at `utils.getParamNames`. (#1474) This was a bug at `fn-args` library that got fixed with sindresorhus/fn-args#10 * docs: fix bootstrap description for custom runner documentation (#1471) * Make overriding option in `run-multiple` to respect the generated overridden config (#1466) * WIP: Fix deep merge for container.append(). Use lodash.merge() (#1475) * remove unnecessary import * use lodash merge * fix lint * use lodash.merge * Fix/1422 save screenshot on windows (#1470) * synced with master (#1) * Added WebDriver to autoDelay supported helpers (#1455) WebDriverIO is deprecated and should be removed from the list when the deprecation notices are removed. * Fix multiple-execution link (#1456) * add label to allure report + fix collect tag (#1449) * Skip test in allure-report (#1448) * Fix issue 1445 and 1443 (#1446) * Fix running tests with different data and with only * fix * remove only * fix comment * fix comments * fix issue 1443 * use JSON.stringify for all obj * Change setValue() to addValue() (and add some tests) (#1460) * improved TS definitions * fixed the case when there are more than one matched element (#1453) * fixed the case when there are more than one matched element * fixed the same thing for nightmare and protractor * prepare release and website update * fixed the case the folder to save screenshot is duplicated on windows * fixed the case the folder to save screenshot is duplicated on windows * lint fixed * removed the lib * Fix url protocol detection for non-http urls (#1486) * add non-http protocols processing for puppeteer, nightmare, protractor. * make puppeteer slider test local * Fix Dynamic Injection (#1485) * Move injectDependencies() into ScenarioConfig * Add injectDependencies() test * add parameter to emitting event (#1483) * Enable to use Step-by-step Report for WebDriver Plugin (#1482) * Enable Step-By-Step Report to WebDriverIO5 * remove ANSI escape string * grabHTMLFrom returns array of innerHTML from the set of matched elements (#1481) * fix bootstrapall and teardownall launch with path as argument (#1484) * add possibility to define conditional checks interval for waituntil in webdriverio (#1490) * Fix bootstrapAll and teardownAll calls from exported object (#1492) * rename called hook * add tests for bootstrapall and teardownall call * update bootstrapall teardownall doc * update bootstrapall doc link * fix bootstrapall doc link * add husky rules for pre-commit and pre-push (#1489) * Add all data for test instance (#1501) * fix cloud provider hostname rewrite (#1506) * Drag slider for WebDriver (#1505) * Added dragSlider to WebDriver * added dragSlider method to WebDriver * update the deprecated method of wdio v5 (#1519) * Add Japanese translation file (#1510) * add japanese translation * Add japanese documentation and how to use custom translation file * Fix/locator method withChild (#1513) * add method for finds ancestor of located element * fix test name * fix withChild * fix withChild * fix * fix * fix by comment * Add doc for IE 11 and selenoid (#1516) * Add doc for IE 11 * add doc for selenoid * add link * Restore original window size when taking full size screenshot (#1508) * Restore original window size when taking full size screenshot * Return screenshot buffer * New puppeteer plugin to dump code coverage (#1504) * Create new puppeteer plugin to dump code coverage * fixed some lint errors * ran lint -fix * update from cr * Update reports.md (#1514) * Visual Testing in General, Guide Version 1 (#1404) * Visual Testing in General Guide-version 1.0 * Minor change * Adding Images for Visual Testing Guide * Adding More details to guide, modifying Intro * Updating Visual Diff Read me * Adding Guide for Visual-knight * Minor * Enable ScenarioContext functions for data driven tests (#1503) * added ability to chain the following functions on data scenarios: throws, fails, timeout, config, and tag * scenario apply function outside of dataScenarioConfig * add jsdoc comments * refactor dataScenarioConfig into its own class, no longer adding skipped scenarios to scenarios array, added tests * add blank line between class functions * avoid adding skipped scenarios to scenarios array * preparing 2.0.5 release * restructured docs, added grabHtmlFrom to Nightmare, fixed WebDriver test * implemented custom locators * updated docs * updated images in visual testing guide * fixed formatting for plugins page, added locator to index.js * updated docs * updated changelog * implemented right click for WebDriver, Nightmare (#1531) * WDIO v5 - Updated some deprecated methods (#1525) * Updated some deprecated methods * cr fixes * cr fixes * typescript may not mark async functions correctly so just await everything (#1526) * typescript may not mark async functions correctly so just await everything * scenario tests are always asynchronous * need to wait for the tested test to complete before asserting * fixed no screenshots on passed cases allure (#1496) * fixed no screenshots on passed cases allure * introduced a config option to turn on step by step report for allure * introduced screenshots to allure as a config option * removed redundant text * updated website, added testimonials * styles update * Fix/ withChild and withDescendant work wrong (#1537) * fix * Add negative test * remove only * fix name test * add method "addLabel" for allure (#1540) * updated docs * updated docs * updated docs, version bump * fixed autoLogin local storage example (#1546) * fixed autoLogin local storage example * fixed autoLogin local storage example source * adding downloadFile action for puppeteer (#1542) * adding downloadFile action for puppeteer * CR addressed * fixed tests * lint fixed * debug * removed .only from describe * fixed failed test * lint fixed * Fix typo (#1557) * updated website * Add screenshotDiff for allure report (#1551) * fix locator simplify call, fix toxpath function (#1541) * fixed issue 1561 (#1564) * fxied issue 1561 * removed only :) * handled the case when element has no value attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically to click a button, link in AUT to download file. This file is downloaded to output folder. And this function makes sure download function is working on the application.
For instance: you have a web application that let users can upload/ download their images, documents. By using
I.downloadFile('locator'), if the file is downloaded to output folder, then downloading function is working. Moreover, after the file is downloaded, we can do further check with downloaded file if we want, like parsing the pdf and checking contents, etc.