[Allure report] For deleteSuccessful option set to true in stepByStepReport - passed test cases in Allure still have screenshots attached

[AdamOakman]

What are you trying to achieve?

Only successful test cases should have screenshots attached in Allure report.

What do you get instead?

Every single test case and step (including passed) has a screenshot attached in Allure report.

Provide test source code if related

Details

• CodeceptJS version: 2.0.4
• NodeJS Version: docker
• Operating System: docker
• Protractor
• Configuration file:

    plugins: {
        screenshotOnFail: {
            enabled: true,
            fullPageScreenshots: false
        },
        allure: {
            enabled: true
        },
        autoDelay: {
            enabled: true,
            delayBefore: 100,
            delayAfter: 150
        },
        stepByStepReport: {
            enabled: true,
        }
    },

deleteSuccessful option set to true by default according to documentation

[kobenguyent]

 * ##### Allure Reports
 *
 * If Allure plugin is enabled this plugin attaches each saved screenshot to allure report.
 *
 *

[AdamOakman]

@peterngtr Sorry. My bad. I corrected issue summary and description. I had "deleteSuccessful option set to true by default" on my mind because that's how this works I think. Passed test cases and steps inside Allure still have screenshots attached in this case.

[kobenguyent]

So I think currenty, either test passed or failed when you have allure with stepByStep enabled, screenshots are always attached to allure. :)

[AdamOakman]

That's how it is! Shouldn't we make them attached for passed tests only? if below configuration happens
stepByStepReport: { deleteSuccessful: true, enabled: true }

[kobenguyent]

That combination, I guess yes, a PR is always welcome. :)

[kobenguyent]

@AdamOakman so, screenshotOnFail is enabled by default, you don't need to add this in your config.

also, I pushed a PR to handle this nicely. More details you can find it here #1496

[AdamOakman]

Thank you @peterngtr