Bug: SBA server build breaks with version 4.0.0

[cdprete]

Spring Boot Admin Server information

• Version: 4.0.0

• Spring Boot version: 4.0.2

• Configured Security: None

• Webflux or Servlet application: WebFlux

Client information

Not necessary.

Description

When trying to packaging the application with AOT enabled it fails with

Exception in thread "main" java.lang.IllegalStateException: Error processing condition on de.codecentric.boot.admin.server.cloud.config.AdminServerDiscoveryAutoConfiguration$EurekaConverterConfiguration
	at org.springframework.boot.autoconfigure.condition.SpringBootCondition.matches(SpringBootCondition.java:60)
	at org.springframework.context.annotation.ConditionEvaluator.shouldSkip(ConditionEvaluator.java:100)
	at org.springframework.context.annotation.ConfigurationClassBeanDefinitionReader$TrackedConditionEvaluator.shouldSkip(ConfigurationClassBeanDefinitionReader.java:524)
	at org.springframework.context.annotation.ConfigurationClassBeanDefinitionReader.loadBeanDefinitionsForConfigurationClass(ConfigurationClassBeanDefinitionReader.java:135)
	at org.springframework.context.annotation.ConfigurationClassBeanDefinitionReader.loadBeanDefinitions(ConfigurationClassBeanDefinitionReader.java:124)
	at org.springframework.context.annotation.ConfigurationClassPostProcessor.processConfigBeanDefinitions(ConfigurationClassPostProcessor.java:458)
	at org.springframework.context.annotation.ConfigurationClassPostProcessor.postProcessBeanDefinitionRegistry(ConfigurationClassPostProcessor.java:310)
	at org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanDefinitionRegistryPostProcessors(PostProcessorRegistrationDelegate.java:349)
	at org.springframework.context.support.PostProcessorRegistrationDelegate.invokeBeanFactoryPostProcessors(PostProcessorRegistrationDelegate.java:118)
	at org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:794)
	at org.springframework.context.support.GenericApplicationContext.refreshForAotProcessing(GenericApplicationContext.java:414)
	at org.springframework.context.aot.ApplicationContextAotGenerator.lambda$processAheadOfTime$0(ApplicationContextAotGenerator.java:55)
	at org.springframework.context.aot.ApplicationContextAotGenerator.withCglibClassHandler(ApplicationContextAotGenerator.java:68)
	at org.springframework.context.aot.ApplicationContextAotGenerator.processAheadOfTime(ApplicationContextAotGenerator.java:54)
	at org.springframework.context.aot.ContextAotProcessor.performAotProcessing(ContextAotProcessor.java:107)
	at org.springframework.context.aot.ContextAotProcessor.doProcess(ContextAotProcessor.java:84)
	at org.springframework.context.aot.ContextAotProcessor.doProcess(ContextAotProcessor.java:49)
	at org.springframework.context.aot.AbstractAotProcessor.process(AbstractAotProcessor.java:84)
	at org.springframework.boot.SpringApplicationAotProcessor.main(SpringApplicationAotProcessor.java:96)
Caused by: java.lang.IllegalStateException: Failed to introspect Class [de.codecentric.boot.admin.server.cloud.config.AdminServerDiscoveryAutoConfiguration$KubernetesConverterConfiguration] from ClassLoader [jdk.internal.loader.ClassLoaders$AppClassLoader@5a07e868]
	at org.springframework.util.ReflectionUtils.getDeclaredMethods(ReflectionUtils.java:483)
	at org.springframework.util.ReflectionUtils.doWithMethods(ReflectionUtils.java:360)
	at org.springframework.util.ReflectionUtils.getUniqueDeclaredMethods(ReflectionUtils.java:417)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.lambda$getTypeForFactoryMethod$0(AbstractAutowireCapableBeanFactory.java:750)
	at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1756)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.getTypeForFactoryMethod(AbstractAutowireCapableBeanFactory.java:749)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.determineTargetType(AbstractAutowireCapableBeanFactory.java:683)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.predictBeanType(AbstractAutowireCapableBeanFactory.java:655)
	at org.springframework.beans.factory.support.AbstractBeanFactory.isFactoryBean(AbstractBeanFactory.java:1699)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doGetBeanNamesForType(DefaultListableBeanFactory.java:632)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.getBeanNamesForType(DefaultListableBeanFactory.java:604)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.getBeanNamesForType(DefaultListableBeanFactory.java:589)
	at org.springframework.boot.autoconfigure.condition.OnBeanCondition.collectBeanDefinitionsForType(OnBeanCondition.java:334)
	at org.springframework.boot.autoconfigure.condition.OnBeanCondition.getBeanDefinitionsForType(OnBeanCondition.java:323)
	at org.springframework.boot.autoconfigure.condition.OnBeanCondition.getMatchingBeans(OnBeanCondition.java:221)
	at org.springframework.boot.autoconfigure.condition.OnBeanCondition.evaluateConditionalOnBean(OnBeanCondition.java:158)
	at org.springframework.boot.autoconfigure.condition.OnBeanCondition.getMatchOutcome(OnBeanCondition.java:133)
	at org.springframework.boot.autoconfigure.condition.SpringBootCondition.matches(SpringBootCondition.java:47)
	... 18 more
Caused by: java.lang.NoClassDefFoundError: org/springframework/cloud/kubernetes/commons/discovery/KubernetesDiscoveryProperties
	at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
	at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3010)
	at java.base/java.lang.Class.getDeclaredMethods(Class.java:2329)
	at org.springframework.util.ReflectionUtils.getDeclaredMethods(ReflectionUtils.java:465)
	... 35 more
Caused by: java.lang.ClassNotFoundException: org.springframework.cloud.kubernetes.commons.discovery.KubernetesDiscoveryProperties
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:580)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:490)
	... 39 more

Indeed, my GitLab CI/CD runner that builds the server runs in OpenShift, so it's expected Kubernetes to be selected as cloud platform, but this was not really happening with version 3.5.7 given that I've Eureka configured as service registry.
A @ConditionalOnBean(KubernetesDiscoveryProperties.class) is missing there, in my opinion, similarly how for Eureka there is @ConditionalOnBean(EurekaClient.class).

[cdprete]

I've opened #5083 to fix this.

[hzpz]

I was not able to reproduce the stacktrace above just yet. However, there seems to be an issue with our Eureka runtime example when running with SBA 4.0. We'll have to investigate.

[cdprete]

I was not able to reproduce the stacktrace above just yet. However, there seems to be an issue with our Eureka runtime example when running with SBA 4.0. We'll have to investigate.

Have you enabled AOT?
As you can see from the stack trace, it's doing the introspection of the classes which doesn't really happen without.
I'm following https://docs.spring.io/spring-boot/maven-plugin/aot.html from my side.

Regarding your Eureka playground, it seems to be outdated if you plan to use it with SBA 4 since it requires SB 4.x which, in return, will make the project work only with Spring Cloud 2025.1.x

Finally, that playground doesn't start in a k8s environment, therefore the @ConditionalOnCloudPlatform(KUBERNETES) is enough to make that part of the auto-configuration back off.
The issue arises when SBA runs in such an environment (e.g.: while generating the AOT cache), but it's not configured to use the service discovery mechanism of that environment because another one is wanted (i.e.: Eureka in this case).
In my case, I don't have any dependency of spring-cloud-kubernetes-xyz declared for the reasons explained above.

[SteKoe]

Hi @cdprete,

Regarding your Eureka playground, it seems to be outdated if you plan to use it with SBA 4 since it requires SB 4.x which, in return, will make the project work only with Spring Cloud 2025.1.x

That's right, we have just updated the Eureka Playground Sample to Spring Boot 4.0.2 and Spring Boot Admin 4.0.0. It runs without any problems when not using AOT. When you try to compile using AOT, it breaks, as @RefreshScope is not found. Solution: Disable cloud refresh spring.cloud.refresh.enabled: false (see Spring Cloud Wiki). AOT will work again. Did adding the annotation, as provided in your PR, was sufficient to fix your build?

playground doesn't start in a k8s environment

We cannot reproduce this when using SBA 4.0.0. We were successfully able to build and deploy kubernetes playground project using AOT and without using AOT to a k8s cluster. What was the issue you faced with this playground project?

[cdprete]

Hi @SteKoe.

What was the issue you faced with this playground project?

I didn't personally use it.
I was just replying to @hzpz providing him some hints regarding the issue he mentioned with it.

Disable cloud refresh spring.cloud.refresh.enabled: false (see Spring Cloud Wiki).

I'm aware of it already (I'm running SBA with AOT since day one :)) and, in fact, I already have that entry in my config.

Did adding the annotation, as provided in your PR, was sufficient to fix your build?

Yes, as you can see in the attached screenshot.
The build job first fails (red) and then, with the fix, it passes (green).

We cannot reproduce this when using SBA 4.0.0.

I was mentioning the Eureka playground.
It's only natural that I would expect the Kubernetes playground to work in k8s. :)

[cdprete]

Hello @SteKoe.

You can see in #5090 that indeed it works, since the accordions now have the new style applied ;)