Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableServiceLinks are only used in k8s >= 1.13.0 #43

Merged

Conversation

dojadop
Copy link
Contributor

@dojadop dojadop commented May 28, 2019

Fixes #42

Signed-off-by: Michael Dop michael.p.dop@gmail.com

Fixes codecentric#42

Signed-off-by: Michael Dop <michael.p.dop@gmail.com>
@dojadop dojadop requested a review from unguiculus as a code owner May 28, 2019 18:43
Signed-off-by: Michael Dop <michael.p.dop@gmail.com>
…sKubernetes1.13

# Conflicts:
#	charts/keycloak/Chart.yaml
#	charts/keycloak/templates/statefulset.yaml
Copy link
Contributor

@unguiculus unguiculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

charts/keycloak/templates/statefulset.yaml Outdated Show resolved Hide resolved
use - instead of . for the version compare

Co-Authored-By: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Michael Dop <michael.p.dop@gmail.com>
@dojadop dojadop force-pushed the enableServiceLinksKubernetes1.13 branch from 0b13b18 to 9872159 Compare June 1, 2019 12:51
@unguiculus unguiculus merged commit d31685c into codecentric:master Jun 3, 2019
dnplkndll pushed a commit to Kencove/codecentric-helm-charts that referenced this pull request Jun 26, 2024
…instance, partial fix for T2868 (codecentric#43)

This requires both web.enabled = true and longpolling.enabled = true to
function correctly. We do not support just longpolling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enableServiceLinks only available in kubernetes >= 1.13
3 participants