Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keycloak] Fix ingress route output in NOTES.txt #451

Closed
thomasdarimont opened this issue Jul 20, 2021 · 0 comments · Fixed by #452
Closed

[Keycloak] Fix ingress route output in NOTES.txt #451

thomasdarimont opened this issue Jul 20, 2021 · 0 comments · Fixed by #452

Comments

@thomasdarimont
Copy link
Contributor

In https://github.com/codecentric/helm-charts/blob/master/charts/keycloak/templates/NOTES.txt#L12

  - http{{ if $.Values.ingress.tls }}s{{ end }}://{{ $rule.host }}{{ . }}

Should be

  - http{{ if $.Values.ingress.tls }}s{{ end }}://{{ $rule.host }}{{ .path }}
thomasdarimont added a commit to thomasdarimont/helm-charts that referenced this issue Jul 20, 2021
@thomasdarimont
[keycloak] Fix ingress route output (codecentric#451)
5a3954d 
This is related to codecentric#446.

Fixes codecentric#451

Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
@thomasdarimont thomasdarimont mentioned this issue Jul 20, 2021
Merged
mircohacker pushed a commit that referenced this issue Jul 20, 2021
@thomasdarimont
[keycloak] Fix ingress route output (#451)
a82e298 
This is related to #446.

Fixes #451

Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[keycloak] Fix ingress route output (#451) thomasdarimont/helm-charts
1 participant
@thomasdarimont