Begin ITSO card support #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove some unneeded imports from ITSOTransitData.
Split logs into 4 arrays of 48 bytes each.
We can now see two trips and what dates they are on.
Display the hex for unknown companies and routes
|
This is really awesome! Is it possible for you to post an XML dump of a few cards so I can test this out? You can email them to me (eric@codebutler.com) if you'd rather not share publicly. Thanks for your work! |
I now have all 3 companies for which my ticket is valid Route 300 thanks to @pandalion
|
Hey, I rebased your code and pushed it to a branch 476388f. Do you think you'll have any time to fix all the TODOs so this can get merged in? Thanks! |
|
Do you not have any comments about the quality of the code? |
|
@rjmunro I did make a few changes to better match the style of the rest of the codebase, happy to answer any specific questions. |
|
@rjmunro do you still plan to work on this? |
|
I'm closing this for now. @rjmunro let me know if you'd like to pick this up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITSO is the UK national standard for contactless travel.
So far, I have collected 23 routes from 3 companies in Oxford. There are probably around 100 companies and thousands of routes on the whole system. I've only supported MiFare DESFire cards, as that is all I have access to but other card types are supported by the system.
I'm putting this PR up so that people can comment on my code - I'm trying to learn native Android development, and am not really sure what I am doing. Once the code is tidy, it may be good to get it merged and we can start crowdsourcing all the routes and companies, but it's not ready yet.
Currently, my card displays nothing in the balance tab (my own card doesn't have a balance, it has unlimited travel up to an expiry date, but N trip cards are available for some routes) and the last 2 trips in the trips tab as that seems to be all that is stored. For some reason, the times of the trips are not showing, even though, as far as I know I am decoding and passing them as part of the timestamp.