Change MaskPattern.Patterns to a list

[Shane32]

This code changes MaskPattern.Patterns to a list instead of a dictionary to hopefully make some code easier to understand.

Existing code

The index is stored zero-based within the QR code, and I was confused by this code here:

QRCoder/QRCoder/QRCodeGenerator.ModulePlacer.cs

Line 130 in 14a83f2

var formatStr = GetFormatString(eccLevel, pattern.Key - 1);

followed by

QRCoder/QRCoder/QRCodeGenerator.ModulePlacer.cs

Line 163 in 14a83f2

selectedPattern = pattern.Key;

and

QRCoder/QRCoder/QRCodeGenerator.ModulePlacer.cs

Lines 175 to 176 in 14a83f2

	qrCode.ModuleMatrix[y][x] ^= MaskPattern.Patterns[selectedPattern.Value](x, y);
	qrCode.ModuleMatrix[x][y] ^= MaskPattern.Patterns[selectedPattern.Value](y, x);

which is actually correct because of

QRCoder/QRCoder/QRCodeGenerator.ModulePlacer.cs

Line 185 in 14a83f2

return selectedPattern.Value - 1;

So since the dictionary is unnecessary, I converted it to a list. It should be faster too but I didn't check.

New code

Now we start with this:

QRCoder/QRCoder/QRCodeGenerator.ModulePlacer.cs

Lines 118 to 120 in d48a2fb

	for (var maskPattern = 0; maskPattern < 8; maskPattern++)
	{
	var patternFunc = MaskPattern.Patterns[maskPattern];

and uses are simple:

QRCoder/QRCoder/QRCodeGenerator.ModulePlacer.cs

Line 132 in d48a2fb

var formatStr = GetFormatString(eccLevel, maskPattern);

QRCoder/QRCoder/QRCodeGenerator.ModulePlacer.cs

Line 165 in d48a2fb

selectedPattern = maskPattern;

QRCoder/QRCoder/QRCodeGenerator.ModulePlacer.cs

Line 187 in d48a2fb

return selectedPattern.Value;

[Shane32]

I'll need to fix conflicts here

[codebude]

Can you also have a look on the merge conflicts?