Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflows #492

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Fix workflows #492

merged 3 commits into from
Apr 2, 2024

Conversation

Shane32
Copy link
Contributor

@Shane32 Shane32 commented Apr 2, 2024

Summary

  • Fixes GitHub Action workflows.
  • Removes ifdef for hashes on NETFX. Not sure why they were there, but tests fail unless they are removed, both locally and within CI.

@Shane32 Shane32 mentioned this pull request Apr 2, 2024
Merged
Shane32
Shane32 commented Apr 2, 2024
View reviewed changes
.github/workflows/wf-build-release-ci.yml
name: Checkout Code

- name: Install additional .NET SDKs
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
Copy link
Contributor Author

@Shane32 Shane32 Apr 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, I've had numerous problems with actions/setup-dotnet on other GitHub workflows that are still using v1; bumping to v4 has fixed those problems for me in the past.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, then let's use v4. I just ised v1 because it was the up-to-date version when setting up the workflow.

@codebude
Copy link
Owner

codebude commented Apr 2, 2024

Summary

  • Removes ifdef for hashes on NETFX. Not sure why they were there, but tests fail unless they are removed, both locally and within CI.

Full explanation why the ifdef was used: #455
But since I also can't replicate the behaviour (there might have been a change anywhere down the PNG encoder lane), I'm fine with removing them.

@codebude codebude merged commit dfa5209 into codebude:master Apr 2, 2024
3 checks passed
@Shane32 Shane32 deleted the fix_workflows branch April 2, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebude codebude codebude left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shane32 @codebude