Implementation of ByteMatrixQRCode #449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements ByteMatrixQRCode, which allows a byte matrix representation of the generated QR Code data
|
Hi @Benjlet , late (probably too late) reply, but doesn't this somehow duplicate the "raw data" export of QRCoder? The raw data export aims to export the "black/white" information in the most space efficient way to be shared with other applications. See: https://github.com/codebude/QRCoder/wiki/Advanced-usage---QR-Code-raw-data-export |
|
Hey @codebude, I didn't see that was already an option - I personally found this implementation easier to port to other libraries and thought I'd share it out. I will set this to closed but feel free to open if you think there's some value in it being shared in future - cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements 'ByteMatrixQRCode', which allows a byte matrix representation of the generated QR Code data.
I found this to be a very portable format for writing pixels blocks to other image libraries, where these simply translate to a grid of 1s/0s. Originally I was using the ZXing library to achieve this and had to develop that conversion as a wrapper, so believe this is adding something useful.
Unit tests included and all passing for me - I ran this on .NET 6 in VS2022.
I did not update the main README in this request as this would likely be done after/if this is merged, so it can link to the Wiki.
Cheers - love the library.