Feature/decouple xaml code add net6 0 #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: net6.0 isn't added as target for QRCoderConsole because QRCoderConsole heavily relies on System.Drawing which isn't available on net6.0 any longer.
Due to missing support: coverlet-coverage/coverlet#466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR decouples QRCoder and XamlQRCoder. By moving XamlQRCode into an own subproject (
QRCoder.Xaml) and into an own NuGet package, we can remove the Microsoft.WindowsDesktop.App dependencies which may lead to trouble onnet5.0-windowsandnet6.0-windowstargets as described in #353.In addition
net6.0andnet6.0-windowsare added as targets to excludeSystem.Drawingreferences on non-Windows platforms for targetnet6.0.This PR (hopefully) fixes the following bugs/features:
net6.0andnet6.0-windowsas new target frameworks (to avoid problems withSystem.Drawing)Test plan
Assertion for merge: Build job should pass all tests successfully.
Related issues
This pull request relates to #353, #354 and (probably) #356.