Skip to content

add mock db and server. update packages #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2019

Conversation

jonnyfluckey
Copy link
Contributor

#15

I did a few things to try and make this easy. If you were thinking something else, please let me know.

  1. Used the file provided to me to set up the JSON mock information.
  2. Added JSON-Server NPM package to launch a mock server.
  3. Set up the NPM start script to run React and JSON-server concurrently. That way, the server data is live and can be tested instantly.

Let me know if you have any questions or feedback.

Thanks!

@lpatmo
Copy link
Member

lpatmo commented Oct 22, 2019

@jonnyfluckey Oof sorry, my attempt to resolve merge conflicts caused the build to break XD. Working on fixing now.

@jonnyfluckey
Copy link
Contributor Author

Thanks!

One thing I forgot to mention. For JSON server, you may have to install the NPM package globally in order to get it to run locally (I think it has to be that way in order for the script command to work)

@lpatmo
Copy link
Member

lpatmo commented Oct 22, 2019

Thanks Jonny! :) I am going to merge your PR in. I didn't know about https://github.com/typicode/json-server before, so this is fantastic.

Note to self: the easiest way to fix package-lock.json syntax errors is to rm the file and re-run npm install

@lpatmo lpatmo merged commit 770992f into codebuddies:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants