Skip to content

[Do Not Merge] Issue 55 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Do Not Merge] Issue 55 #153

wants to merge 4 commits into from

Conversation

angelocordon
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🎨 Enhancement
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Context

Placeholder example: This PR closes issue #12

Screenshots/Recordings (if there are UI changes)

Placeholder example: ![screenshot of new resource page](https://user-images.githubusercontent.com/43/23.png)

Note: you can upload a screenshot onto your PR and put it here.

Implementation Details - what was your thought process as you changed the code?

Placeholder example:
[x] Made an axios GET request to /resources
[x] Refactored to use useQuery library
[x] Wrote tests

Related Tickets & Documents (Optional)

Placeholder example: This relates to issue #23.

Filed issue #43 as a next step to do after this PR is merged.

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation (readme.md or contributing.md)?

  • 📜 readme.md
  • 📜 contributing.md
  • 🙅 no documentation needed
  • 🙋 I'd like someone to help write documentation, and will file a new issue for it

@angelocordon angelocordon added the do not merge Notify maintainers not to merge a PR (yet) label Sep 12, 2020
@lpatmo
Copy link
Member

lpatmo commented Sep 13, 2020

@angelocordon I'm so sorry, I just noticed that this branch is issue-55, and the most up-to-date branch is issue55-post at #154, which I've opened up a draft PR for. Closing this now!

@lpatmo lpatmo closed this Sep 13, 2020
@angelocordon angelocordon deleted the issue-55 branch September 13, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Notify maintainers not to merge a PR (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants