[Issue 125 Fix] : Added Serializer Field to Properly Resolve Choices in Resource.media_type Field #140
Conversation
…on to fetch proper display name and added a serializer.ChoiceField to handle the choices option.
…d create_one_resource_without_media_type test.
BethanyG
changed the title
BethanyG
changed the title
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 81.44% 82.88% +1.43%
==========================================
Files 29 29
Lines 469 479 +10
==========================================
+ Hits 382 397 +15
+ Misses 87 82 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Awesome, thanks so much for fixing that media_type error! :D Confirmed that when I create a new resource with a blank field for media_type, it passes; if I create a resource with an invalid field, I get an error; if I create a new resource without a media_type field, I get an expected error.
Left one question about the key error returned if I pass in invalid media type... the tests pass, but I didn't see an expected list when I tried it out on Postman (see other comment).
| @@ -1,4 +1,5 @@ | |||
| from unittest import skip | |||
| from pytest import raises | |||
There was a problem hiding this comment.
Nice, didn't know about pytest.raises 👍
Should fix #125.
Added
class MediaTypeSerializerField(serializers.ChoiceField)with ato_representationand ato_internal_valueto properly resolve thechoiceson theResource.media_typefield for Resources. inresources/serializers.pyCorrected and un-commented the
create_one_resource_with_media_typetest case and added a newcreate_one_resource_without_media_typetest case for coverage. inresources/tests.py