Add PHPStan and modify error handling in BadgeComposer #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds PHPStan and its related strict rules and deprecation rules to the `composer.json`. It also modifies the `finalizeCoverage` method in `BadgeComposer` to handle errors when badge template file is missing. A test for this scenario has been added to `BadgeComposerTest.php`.
This commit corrects a misspelling of 'manipulate' and changes the expected error type in BadgeComposerTest's finalizeCoverage method. The test now anticipates a Throwable exception when a badge template file is missing, enhancing error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds PHPStan and its related strict rules and deprecation rules to the
composer.json. It also modifies thefinalizeCoveragemethod inBadgeComposerto handle errors when badge template file is missing. A test for this scenario has been added toBadgeComposerTest.php.