Skip to content

feat: Support AWS CDK v2 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Contributing

PR's are are welcome and encouraged in this repository. Read this document to see how to contribute.
PR's are welcome and encouraged in this repository. Read this document to see how to contribute.

## Table of Contents

Expand Down Expand Up @@ -76,13 +76,13 @@ npm link
Finally, in the project that you want to test, run:

```
yarn link @codebrew/{plugin}
yarn link @efacity/{plugin}
```

Or:

```
npm link @codebrew/{plugin}
npm link @efacity/{plugin}
```

# Pull Requests
Expand Down
19 changes: 10 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
![NPM](https://img.shields.io/npm/l/@codebrew/nx-aws-cdk)
![NPM](https://img.shields.io/npm/l/@efacity/nx-aws-cdk)
[![standard-readme compliant](https://img.shields.io/badge/standard--readme-OK-green.svg?style=flat-square)](https://github.com/RichardLitt/standard-readme)

<hr>

# Codebrew Nx Plugins
# Efacity Nx Plugins

A collection of third-party Nx plugins.
A collection of third-party Nx plugins based on Codebrew (https://github.com/codebrewlab/nx-plugins)
Codebrew no longer maintained the plugin and accepts pull requests to continue the development.

## Table of Contents

- [Codebrew Nx Plugins](#codebrew-nx-plugins)
- [AWS CDK Nx Plugins](#aws-cdk-nx-plugins)
- [Table of Contents](#table-of-contents)
- [Plugins](#plugins)
- [Maintainers](#maintainers)
Expand All @@ -18,13 +19,13 @@ A collection of third-party Nx plugins.

## Plugins

| Plugin | Description |
| --------------------------------------------------------- | --------------------------------------------------------------------------------------------- |
| [`@codebrew/nx-aws-cdk`](./packages/nx-aws-cdk/README.md) | An Nx plugin for developing [aws-cdk](https://docs.aws.amazon.com/cdk/latest/guide/home.html) |
| Plugin | Description |
| -------------------------------------------------------- | --------------------------------------------------------------------------------------------- |
| [`@efacity/nx-aws-cdk`](./packages/nx-aws-cdk/README.md) | An Nx plugin for developing [aws-cdk](https://docs.aws.amazon.com/cdk/latest/guide/home.html) |

## Maintainers

[@tienne](https://github.com/tienne)
[@efacity](https://github.com/efacity)

## Contributing

Expand All @@ -36,4 +37,4 @@ If editing the README, please conform to the [standard-readme](https://github.co

## License

This project is MIT licensed 2021 David Kwon.
This project is MIT licensed.
8 changes: 4 additions & 4 deletions e2e/nx-aws-cdk-e2e/tests/aws-cdk.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@ import { checkFilesExist, ensureNxProject, readJson, runNxCommandAsync, uniq } f

describe('nx-aws-cdk e2e', () => {
beforeAll(() => {
ensureNxProject('@codebrew/nx-aws-cdk', 'dist/packages/nx-aws-cdk');
ensureNxProject('@efacity/nx-aws-cdk', 'dist/packages/nx-aws-cdk');
});

it('should create aws-cdk', async () => {
const plugin = uniq('nx-aws-cdk');

await runNxCommandAsync(`generate @codebrew/nx-aws-cdk:application ${plugin}`);
await runNxCommandAsync(`generate @efacity/nx-aws-cdk:application ${plugin}`);
}, 120000);

describe('--directory', () => {
it('should create src in the specified directory', async () => {
const plugin = uniq('nx-aws-cdk');

await runNxCommandAsync(`generate @codebrew/nx-aws-cdk:application ${plugin} --directory subdir`);
await runNxCommandAsync(`generate @efacity/nx-aws-cdk:application ${plugin} --directory subdir`);
expect(() => checkFilesExist(`apps/subdir/${plugin}/src/main.ts`)).not.toThrow();
}, 120000);
});
Expand All @@ -24,7 +24,7 @@ describe('nx-aws-cdk e2e', () => {
it('should add tags to nx.json', async () => {
const plugin = uniq('nx-aws-cdk');

await runNxCommandAsync(`generate @codebrew/nx-aws-cdk:application ${plugin} --tags e2etag,e2ePackage`);
await runNxCommandAsync(`generate @efacity/nx-aws-cdk:application ${plugin} --tags e2etag,e2ePackage`);
const nxJson = readJson('nx.json');
expect(nxJson.projects[plugin].tags).toEqual(['e2etag', 'e2ePackage']);
}, 120000);
Expand Down
222 changes: 203 additions & 19 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading