Skip to content

unload python plugins when geanypy is deactivated - #22

Closed
ghost wants to merge 9 commits into
masterfrom
unknown repository
Closed

ghost wants to merge 9 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 5, 2015

Copy link
Copy Markdown

This should fix bug #12
when the geanypy plugin's cleanup is called it closes the python plugin manager and unloads all the python plugins

@ghost

ghost commented Jul 6, 2015

Copy link
Copy Markdown
Author

You are completely right, sorry about that, first pull request on github.
I'll fix the leak tonight and ammend the indentation, my editor (set to auto) has used tabs instead of spaces.

@ghost ghost closed this Jul 6, 2015
@ghost ghost closed this Jul 10, 2015
@ghost

ghost commented Jul 10, 2015

Copy link
Copy Markdown
Author

I'll check to see if i can find a possible leak on _CallObject()

call decref on result of callobject
@ghost ghost reopened this Jul 10, 2015
@ghost

ghost commented Jul 10, 2015

Copy link
Copy Markdown
Author

I call Py_DECREF on the result of the PyObject_CallObject, so it shouldn't leak now

@codebrainz

Copy link
Copy Markdown
Owner

What are all the extra commits/changes about?

@codebrainz

Copy link
Copy Markdown
Owner

I ask because I want to merge the unloading fix before next release but the PR looks a fair bit more involved since my last comments about the leaks.

@ghost ghost closed this Jul 11, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant