Repository navigation
Closed
Conversation
Author
|
You are completely right, sorry about that, first pull request on github. |
added 6 commits
July 8, 2015 22:00
Author
|
I'll check to see if i can find a possible leak on _CallObject() |
call decref on result of callobject
Author
|
I call Py_DECREF on the result of the PyObject_CallObject, so it shouldn't leak now |
Owner
|
What are all the extra commits/changes about? |
Owner
|
I ask because I want to merge the unloading fix before next release but the PR looks a fair bit more involved since my last comments about the leaks. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix bug #12
when the geanypy plugin's cleanup is called it closes the python plugin manager and unloads all the python plugins