Skip to content

missing class from the tutorial example #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2018
Merged

missing class from the tutorial example #389

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a24b669
missing class from the tutorial example
stampycode Mar 20, 2018
f56a934
lowercase 'c'
stampycode Mar 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions html/lesson2/example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ <h2>Why do I like owls so much?</h2>
<li>and lovely</li>
<li>and cuddly</li>
</ol>
<div><img src="images/img4.jpg" alt="cute owl"/></div>
<div><img src="images/img5.jpg" alt="another cute owl"/></div>
<div class="bigimg"><img src="images/img4.jpg" alt="cute owl"/></div>
<div class="bigimg"><img src="images/img5.jpg" alt="another cute owl"/></div>
<a href="http://www.youtube.com/watch?v=gBjnfgnwXic">Watch this video here</a>
<div id="the-quote">
<h4>
Expand All @@ -45,10 +45,10 @@ <h3>Owls:</h3>
</div>
<ul id="links">
<li>
<a href="mailto:social@codebar.io?subject=I love owls :: codebar">Email us</a>
<a href="mailto:social@codebar.io?subject=I love owls :: Codebar">Email us</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry to be pedantic but codebar is always a lowercase c, so this is deliberate :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no worries - there was an uppercase C here:
http://tutorials.codebar.io/html/lesson2/tutorial.html

The text

Download the files required to begin working through the tutorial from here (mac/linux)

Links to a zip file here:
https://gist.github.com/hundred/7332441/download

I didn't know which was correct. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'll update the PR tomorrow.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

</li>
<li>
<a href="mailto:?subject=I love owls :: codebar">Email a friend</a>
<a href="mailto:?subject=I love owls :: Codebar">Email a friend</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, lowercase c

</li>
<li>
<a href="http://twitter.com/home?status=I love owls! via @codebar">Share your love of owls on twitter</a>
Expand Down