Merged
Conversation
0a76ccc to
1d6daf6
Compare
1d6daf6 to
d8db5d6
Compare
olleolleolle
approved these changes
Sep 16, 2025
Collaborator
olleolleolle
left a comment
There was a problem hiding this comment.
This adds the structure, we can introduce content as we go.
Collaborator
|
(Future details here:) And, in the future we can set up the And, the AWS SDK's docs has notes on the two ENV vars to use for credentials; https://docs.aws.amazon.com/sdk-for-ruby/v2/api/Aws/S3/Client.html#initialize-instance_method |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a solution for #2347.
It adds the
sitemap_geneatorgem to pave the way for a future improvement, where we actually add links like workshops and events to the sitemap, regenerate the file in production and store it in S3, so it survives between deployments.For now, this will make all the
404 Not foundforsitemap.xmlgo away.If we want to update the sitemap file, we need to run the rake task.
See https://github.com/kjvarga/sitemap_generator?tab=readme-ov-file#rake-tasks for details on rake tasks.