Issue 1827 add how you found us to user profile#2328
Issue 1827 add how you found us to user profile#2328davidmillen50 wants to merge 7 commits intocodebar:masterfrom
Conversation
Add spacing around how you found us section
Move validation from model to controller so validation doesn't block new user creation and is only valid for the member details page.
Fix failing tests and move other_reason into member params and give param name more description
|
@davidmillen50 when do you think this will be ready for review? I’m really keen to start knowing this information as soon as possible :) |
|
@KimberleyCook I have updated the other PR and it is now up for code review |
mikej
left a comment
mikej
left a comment
There was a problem hiding this comment.
Hi David
Appreciate this one is still just a Draft, but, in case you haven't spotted it, I just wanted to mention there is a separate admin version of the member show page. This is used e.g. when an organiser views the details for a workshop attendee. It might be useful to show the "how you found us" on this page either instead of, or as well as, when the member views their own profile.
The view used is this one:
https://github.com/codebar/planner/blob/121d1a9884efce7173536c6a7c46e030ae34cc26/app/views/admin/members/show.html.haml
which then includes the profile partial:
https://github.com/codebar/planner/blob/121d1a9884efce7173536c6a7c46e030ae34cc26/app/views/admin/members/_profile.html.haml
3 participants
I've added a section for 'How you found us' to the profile page. This section is not yet editable from the profile page. If that's needed I'll create a separate PR. When the 'how you found us' changes to the onboarding page are added to master I'll rebase this PR and the changes will reduce. The changes related only to the profile page are here a4027dc