main/production #36
Merged
main/production #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new PagesTableSeeder to the Codebar seeder configuration, which populates page metadata (titles, descriptions, SEO data) for both German and English locales. The changes enable seeding of page-specific SEO information for various application routes.
- Adds PagesTableSeeder with multilingual page metadata for SEO purposes
- Integrates the new seeder into the existing CodebarSeeder workflow
- Includes helpful command comments for manual seeder execution
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| database/seeders/DatabaseSeeder.php | Adds helpful artisan command comments for manual seeder execution |
| database/seeders/CodebarSeeder.php | Imports and calls the new PagesTableSeeder class |
| database/seeders/Codebar/PagesTableSeeder.php | New seeder that creates page metadata entries for German and English locales |
| 'robots' => 'index,follow', | ||
| 'title' => 'Bringing Innovative Ideas to Life', | ||
| 'description' => 'We listen, think conceptually, and develop software around user needs using open technologies. Your ideas, our expertise.', | ||
| 'image' => 'https://res.cloudinary.com/codebar/image/upload/c_scale,dpr_2.0,f_auto,q_auto,w_1200/www-codebar-ch/seo/seo_codebar.webp', |
There was a problem hiding this comment.
The same image URL is repeated across all page entries. Consider extracting this as a class constant or configuration value to improve maintainability and make it easier to update.
Suggested change
| 'image' => 'https://res.cloudinary.com/codebar/image/upload/c_scale,dpr_2.0,f_auto,q_auto,w_1200/www-codebar-ch/seo/seo_codebar.webp', | |
| 'image' => self::DEFAULT_IMAGE_URL, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.