main/production #31
Merged
main/production #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables CSP (Content Security Policy) nonces by changing the default configuration from true to false and removes the custom csp_nonce() helper function that was previously used to retrieve nonces from Vite.
- Changed default CSP nonce configuration from enabled to disabled
- Removed custom CSP nonce helper function and its associated import
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| config/csp.php | Changed default value for CSP nonce enablement from true to false |
| app/Support/helpers.php | Removed csp_nonce() helper function and unused Vite facade import |
| * Note that this will make your CSP policy less secure. | ||
| */ | ||
| 'nonce_enabled' => env('CSP_NONCE_ENABLED', true), | ||
| 'nonce_enabled' => env('CSP_NONCE_ENABLED', false), |
There was a problem hiding this comment.
Disabling CSP nonces by default reduces security protection against XSS attacks. CSP nonces help prevent execution of unauthorized inline scripts. Consider keeping this enabled unless there's a specific compatibility requirement.
Suggested change
| 'nonce_enabled' => env('CSP_NONCE_ENABLED', false), | |
| 'nonce_enabled' => env('CSP_NONCE_ENABLED', true), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.