main/production #25
Merged
main/production #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for listing Technologies and Open Source projects with new database tables, models, controllers, views, and seeders, along with some minor UI tweaks.
- Introduces
technologiesandopen_sourcesentities: migrations, models, factories, and seeders. - Updates index views and controllers to use external
linkandtitlefields, opening in a new tab. - Minor adjustments to SVG logo size, list-card spacing, and contact seeder data.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/views/layouts/_logos/_codebar.blade.php | Reduced SVG height from h-10 to h-9. |
| resources/views/components/list-card.blade.php | Added mt-1 to tag container for spacing. |
| resources/views/app/technologies/index.blade.php | Switched to entry->link and entry->title, added target="_blank". |
| resources/views/app/open-source/index.blade.php | Same updates as technologies view. |
| database/seeders/Paperflakes/ContactsTableSeeder.php | Changed LinkedIn icon URL to a profile link. |
| database/seeders/CodebarSeeder.php | Registered new OpenSource and Technologies seeders. |
| database/seeders/Codebar/TechnologiesTableSeeder.php | Added seeder for technologies. |
| database/seeders/Codebar/OpenSourceTableSeeder.php | Added seeder for open source projects. |
| database/seeders/Codebar/NewsTableSeeder.php | Added news seeder entries. |
| database/migrations/2025_06_24_063716_create_technologies_table.php | Created technologies table migration. |
| database/migrations/2025_06_24_063710_create_open_sources_table.php | Created open_sources table migration. |
| database/factories/TechnologyFactory.php | Scaffolded factory without default state. |
| database/factories/OpenSourceFactory.php | Scaffolded factory without default state. |
| app/Models/Technology.php | Model and casts for technologies. |
| app/Models/OpenSource.php | Model and casts for open_sources. |
| app/Http/Controllers/Technologies/TechnologiesIndexController.php | Updated view name and data binding. |
| app/Http/Controllers/OpenSource/OpenSourceIndexController.php | Updated view name and data binding. |
| app/Http/Controllers/OpenSource/OpenSoruceShowController.php | Updated view name for show page (file/class has typo). |
| app/Actions/ViewDataAction.php | Added technologies and openSource data retrieval methods. |
Comments suppressed due to low confidence (4)
app/Http/Controllers/OpenSource/OpenSoruceShowController.php:11
- The class and filename are misspelled ('OpenSoruceShowController'); consider renaming both to 'OpenSourceShowController' for consistency.
class OpenSoruceShowController extends Controller
database/factories/TechnologyFactory.php:20
- [nitpick] The factory is empty and does not define any default state; consider adding attribute definitions to support model testing.
//
database/factories/OpenSourceFactory.php:20
- [nitpick] The factory is empty and does not define any default state; consider adding attribute definitions to support model testing.
//
app/Http/Controllers/OpenSource/OpenSoruceShowController.php:16
- The controller method still uses
Product $product; it should accept theOpenSourcemodel (e.g.,OpenSource $entry) to match the resource being shown.
public function __invoke(string $locale, Product $product): View
| :teaser="$entry->teaser" | ||
| :tags="$entry->tags"/> | ||
| :tags="$entry->tags" | ||
| target="_blank"/> |
There was a problem hiding this comment.
When using target="_blank", add rel="noopener noreferrer" to mitigate reverse tabnabbing vulnerabilities.
Suggested change
| target="_blank"/> | |
| target="_blank" rel="noopener noreferrer"/> |
| :teaser="$entry->teaser" | ||
| :tags="$entry->tags"/> | ||
| :tags="$entry->tags" | ||
| target="_blank"/> |
There was a problem hiding this comment.
When using target="_blank", add rel="noopener noreferrer" to mitigate reverse tabnabbing vulnerabilities.
Suggested change
| target="_blank"/> | |
| target="_blank" rel="noopener noreferrer"/> |
| 'icons' => [ | ||
| 'email' => 'mischa.lanz@paperflakes.ch', | ||
| 'linkedin' => 'https://www.realestateclub.ch/images/REC_social_linkedin.svg', | ||
| 'linkedin' => 'https://www.linkedin.com/in/mischa-lanz-672a65112', |
There was a problem hiding this comment.
The icons['linkedin'] key now points to a profile URL instead of an icon asset; consider restoring the SVG path and introducing a separate linkedin_url field for the link.
Suggested change
| 'linkedin' => 'https://www.linkedin.com/in/mischa-lanz-672a65112', | |
| 'linkedin' => 'linkedin-icon.svg', |
| 'content' => Arr::get($data, 'content'), | ||
| 'link' => $link, | ||
| 'downloads' => $downloads, | ||
| 'version' => $downloads, |
There was a problem hiding this comment.
The version field is incorrectly set to $downloads; it should use the $version parameter ('version' => $version).
Suggested change
| 'version' => $downloads, | |
| 'version' => $version, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.