main/production #24
Merged
main/production #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements production-related endpoint adjustments and configuration updates for the main application. Key changes include new route definitions for technologies and open source, modifications to view components with new conditional settings, and updates to configuration seeders/migrations and controller actions.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| routes/web.php | Added routes for technologies and open source; adjusted legal, jobs, and media route order. |
| resources/views/layouts/_partials/_navigation_mobile.blade.php | Added conditional rendering for services and products sections. |
| resources/views/layouts/_partials/_navigation_desktop.blade.php | Added conditional rendering for services, products, technologies, and open source sections. |
| resources/views/layouts/_partials/_navigation.blade.php | Removed redundant comment regarding navigation toggle. |
| resources/views/layouts/_partials/_footer.blade.php | Updated footer links with configuration checks and revised order of Media and Jobs links. |
| resources/views/components/list-image-card.blade.php | Updated mailto link for email icons. |
| lang/de_CH.json | Revised translation for "Jobs" to "Stellen". |
| Various seeders and migrations | Introduced new configuration fields and added/enhanced localized role entries in seeders. |
| Controllers (Technologies, OpenSource, Media, Legal, Jobs) | Added new controllers and updated existing ones to support redirection logic (@todo remains). |
Comments suppressed due to low confidence (1)
routes/web.php:14
- There appears to be a typo in the controller name 'OpenSoruceShowController'; consider renaming it to 'OpenSourceShowController' to match the expected naming convention.
use App\Http\Controllers\OpenSource\OpenSoruceShowController;
Comment on lines
+19
to
+20
| return view('app.products.index')->with([ | ||
| 'page' => (new PageAction(locale: null, routeName: 'products.index'))->default(), |
There was a problem hiding this comment.
The controller for technologies is rendering the 'app.products.index' view; if this is unintentional, please update it to a technology-specific view.
Suggested change
| return view('app.products.index')->with([ | |
| 'page' => (new PageAction(locale: null, routeName: 'products.index'))->default(), | |
| return view('app.technologies.index')->with([ | |
| 'page' => (new PageAction(locale: null, routeName: 'technologies.index'))->default(), |
Comment on lines
+19
to
+20
| return view('app.products.index')->with([ | ||
| 'page' => (new PageAction(locale: null, routeName: 'products.index'))->default(), |
There was a problem hiding this comment.
The open source controller is using the 'app.products.index' view; if this is not intended, consider updating it to render an open source-specific view.
Suggested change
| return view('app.products.index')->with([ | |
| 'page' => (new PageAction(locale: null, routeName: 'products.index'))->default(), | |
| return view('app.open-source.index')->with([ | |
| 'page' => (new PageAction(locale: null, routeName: 'open-source.index'))->default(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.