Skip to content

main/production #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StanBarrows merged 3 commits into from
Jun 23, 2025
Merged

main/production #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e6e54c
wip
StanBarrows Jun 23, 2025
bdda8a6
Merge branch 'main' of github.com:codebar-ag/www.paperflakes.ch
StanBarrows Jun 23, 2025
00823b1
wip
StanBarrows Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/Actions/ViewDataAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ public function contacts(string $locale): object
ContactSectionEnum::EMPLOYEE_ADMINISTRATION,
ContactSectionEnum::COLLABORATIONS,
ContactSectionEnum::BOARD_MEMBERS,
])->mapWithKeys(function (string $section) use ($publishedContacts, $locale) {
])->mapWithKeys(function (string $section) use ($publishedContacts, $locale): array {
$contacts = $publishedContacts
->filter(function ($contact) use ($section) {
->filter(function (Contact $contact) use ($section): bool {
$sections = $contact->sections ?? [];

return array_key_exists($section, $sections);
})
->map(fn ($contact) => ContactDTO::fromModel($contact, $section, $locale));
->map(fn (Contact $contact) => ContactDTO::fromModel($contact, $section, $locale));

return [$section => $contacts->values()];
})->all();
Expand Down
2 changes: 1 addition & 1 deletion resources/views/app/about-us/index.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
<x-list-image-card
:name="$contact->name"
:image="$contact->image"
image-container-class-attributes="h-20 w-auto flex-shrink-0 overflow-hidden"/>
image-container-class-attributes="h-20 w-20 flex-shrink-0 overflow-hidden"/>
Copy link

Copilot AI Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update changes the width from 'w-auto' to 'w-20', which may introduce inconsistency with other parts of the application if not intended; please verify if a fixed width is the desired behavior.

Suggested change
image-container-class-attributes="h-20 w-20 flex-shrink-0 overflow-hidden"/>
image-container-class-attributes="h-20 w-auto flex-shrink-0 overflow-hidden"/>

Copilot uses AI. Check for mistakes.
@endforeach
</x-list-grid>
</x-section>
Expand Down
2 changes: 1 addition & 1 deletion resources/views/components/list-image-card.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@props([
'image',
'imageContainerClassAttributes' => 'h-30 w-auto flex-shrink-0 overflow-hidden',
'imageContainerClassAttributes' => 'h-30 h-30 flex-shrink-0 overflow-hidden',
Copy link

Copilot AI Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class attribute contains a duplicate 'h-30'. If this is unintentional, consider replacing the duplicate with the intended width class (e.g., 'w-auto').

Suggested change
'imageContainerClassAttributes' => 'h-30 h-30 flex-shrink-0 overflow-hidden',
'imageContainerClassAttributes' => 'h-30 flex-shrink-0 overflow-hidden',

Copilot uses AI. Check for mistakes.
'name',
'role' => null,
'icons' => [],
Expand Down