Skip to content

Windows-related patches, and a couple util patches #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 24, 2019

Conversation

LunarWatcher
Copy link
Contributor

Problems (theoretically) fixed:

  • Opening a file from NERDTree that exists on a different server destroys the NERDTree buffer and breaks :NERDTreeToggle. If relevant, closes splits (including intended persistent ones)
  • Doesn't work with deep paths (SomeFile.txt is fine, D:\some\path\SomeFile.txt is not) - Windows only
  • Window change doesn't doesn't focus on Windows
    • Patch: Call remote_foreground() instead of foreground() on Windows. See :help foreground(): "On Win32 systems this might not work, the OS does not always allow a window to bring itself to the foreground.". remote_foreground() (:help remote_foreground()) is called on Windows because it brings focus to a non-minimized window. From my testing, both are required. Gotta love Windows.
  • The script some times claims there's a recursive swap when there isn't
    • Patch: flip s:in_remote_open to 0 instead of 1 on line 43 (previously line 41). Might be a typo?

@codeape2 codeape2 merged commit a5ce5c8 into codeape2:master Sep 24, 2019
@codeape2
Copy link
Owner

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants