Small tidy ups + Focus acquisition #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we open a buffer in a separate vim instance, bring it to the foreground and switch focus to avoid mouse usage/having to hunt down the window.
Move the .vim file into a plugin/ folder so that plugin managers will autoload it.
Keep our own augroup of autocmds to limit our clearing scope.
When this happens, just prompt the user like in usual scenarios. This can happen with old dangling swap files (that the user might want to recover).
Don't want to pollute the local buffer list.
|
Great, will merge your changes and add a license, thanks! I am more of a PyCharm user these days I must confess - but still use vim occasionally. Do the tests still work? |
|
I tested this manually because the tests weren't passing for me on codeape2:master. The two monitor tests work fine, but the three monitor test fails. I get the same results on lostgoat:master, two monitor test passes, but three fails. Btw, you might want to update the README as well to s/lostgoat/codepe2/g. Otherwise the installation instructions will point to my repo :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Found you plugin pretty useful. I made a few cleanups and added an extra feature to acquire focus on the remote server when a buffer is opened there.
Could I also trouble you to add a license to your repo? Currently unlicensed code is technically not allowed to be used by anyone else.
Thanks for the great plugin!
Andres