[CM-1253] Add dim effect to buttons #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPDATE] change opacity for disable button, updated images, updated test cases
SahilSainiYML
force-pushed
the
feature/CM-1253-AddDimEffectAccessibilty
branch
from
948c765 to
576828d
Compare
mpospese
reviewed
Mar 21, 2023
mpospese
reviewed
Mar 21, 2023
WestonHanners
approved these changes
Mar 21, 2023
mpospese
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Buttons should be disable once reach to max or min value.
Purpose
Increment and decrement buttons should be disable when the current value is equal to maximum or minimum value respectively.
Scope
Disable functionality for increment and decrement button.
📱 Screenshots
Disable increment button. Max value is set to 10.
Disable decrement button. Min value is set to 0.
📈 Coverage
Code
Code coverage is ~97.5%.
Documentation
100% documentation of public APIs.
