Skip to content

[CM-1205] Create Basic Stepper #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

SahilSainiYML
Copy link
Contributor

@SahilSainiYML SahilSainiYML commented Mar 9, 2023

Introduction

Add basic Stepper.

Purpose

Added a new basic component YStepper.

Scope

New UI component added.

📱 Screenshots

Before
Screenshot 2023-03-09 at 1 53 05 PM

Now
Screenshot 2023-03-10 at 2 36 42 PM

📈 Coverage

Code

~95% test code coverage.
Screenshot 2023-03-09 at 1 56 01 PM

Documentation

100% documentation covered for public APIs.
Screenshot 2023-03-09 at 1 53 56 PM

@SahilSainiYML SahilSainiYML requested a review from mpospese March 10, 2023 09:08
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename Classes to UIKit and Views to SwiftUI. That clarifies the code organization better.

@mpospese mpospese force-pushed the feature/CM-1205-CreateBasicStepper branch from 19a5ab3 to 68b5ed2 Compare March 13, 2023 11:18
@mpospese mpospese merged commit 418ebb0 into main Mar 13, 2023
@mpospese mpospese deleted the feature/CM-1205-CreateBasicStepper branch March 13, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants