-
Notifications
You must be signed in to change notification settings - Fork 1
[CM-1205] Create Basic Stepper #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpospese
reviewed
Mar 9, 2023
mpospese
reviewed
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename Classes
to UIKit
and Views
to SwiftUI
. That clarifies the code organization better.
Sources/YStepper/Classes/StepperControl+AppearanceObserver.swift
Outdated
Show resolved
Hide resolved
mpospese
reviewed
Mar 10, 2023
19a5ab3
to
68b5ed2
Compare
mpospese
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Add basic Stepper.
Purpose
Added a new basic component YStepper.
Scope
New UI component added.
📱 Screenshots
Before

Now

📈 Coverage
Code
~95% test code coverage.

Documentation
100% documentation covered for public APIs.
