Skip to content

[CM-1260] Add trait for better accessibility. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

SahilSainiYML
Copy link
Contributor

Introduction

Make Stepper as adjustable element(UIKit) and add accessibilityAdjustableAction for SwiftUI.

Purpose

Making Stepper as adjustable will help making Stepper more accessible. By swipe up and down to change value that will help user who need accessibility.
Fix #8

📱 Screenshots

For UI work, please include before/after screenshots hosted in a 2-column table for easy side-by-side comparison.

🎬 Video

Stepper.mp4

📈 Coverage

Code

~96% code coverage.
Code coverage

Documentation

100% documentation of public APIs.
Jazzy report

Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, Sahil. Let's just expand the test coverage a little.

@SahilSainiYML SahilSainiYML requested a review from mpospese March 22, 2023 12:31
@WestonHanners
Copy link

This is great, 👏

Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just tweak that increment test to test maximum and we're good.

@SahilSainiYML SahilSainiYML force-pushed the feature/CM-1260-AddTraitForBetterAccessibility branch from d0bfff8 to 6d1c8a7 Compare March 23, 2023 06:24
[UPDATE] test case update
@SahilSainiYML SahilSainiYML force-pushed the feature/CM-1260-AddTraitForBetterAccessibility branch from 6d1c8a7 to ac5d967 Compare March 23, 2023 06:39
@SahilSainiYML SahilSainiYML merged commit d929eee into main Mar 23, 2023
@SahilSainiYML SahilSainiYML deleted the feature/CM-1260-AddTraitForBetterAccessibility branch March 23, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Implement "Adjustable" trait for improved accessibility.
3 participants